Url.parseMarkers - Code Metrics - Inspection of "refactoring" - flopp/FloppsMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 137f54...278f6d )

by Florian

created 2017-11-12 15:47 UTC

Url.parseMarkers A

↳ Parent: js/url.js

Complexity

Conditions	3
Paths	17

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
nc	17
nop	1
dl	0
loc	72
rs	9.102

2 Functions

Rating	Name	Duplication	Size	Complexity
A		0	3	1
C		0	51	10

How to fix Long Method

/*jslint
  indent: 4
*/
/*global
  google, window,
  App, Coordinates,
  alpha2id
*/

var Url = {};

Url.getParams = function () {
    'use strict';

    var params = {},
        splitted = window.location.search.substr(1).split('&'),
        i,
        p;

    for (i = 0; i < splitted.length; i += 1) {
        p = splitted[i].split('=', 2);
        if (p[0] !== "") {
            if (p.length === 1) {
                params[p[0]] = "";
            } else {
                params[p[0]] = decodeURIComponent(p[1].replace(/\+/g, " "));
            }
        }
    }

    return params;
};

Url.parseMarkers = function (urlarg) {
    'use strict';

    if (!urlarg) {
        return [];
    }

    var data;

    // ID:COODRS:R(:NAME)?|ID:COORDS:R(:NAME)?
    // COORDS=LAT:LON or DEG or DMMM
    if (urlarg.indexOf("*") >= 0) {
        data = urlarg.split('*');
    } else {
        /* sep is '|' */
        data = urlarg.split('|');
    }

    return data.map(function (dataitem) {
        dataitem = dataitem.split(':');
        if (dataitem.length < 3 || dataitem.length > 6) {
            return null;
        }

        var m = {
                alpha: dataitem[0],
                id: alpha2id(dataitem[0]),
                name: null,
                coords: null,
                r: 0,
                color: ""
            },
            index = 1,
            lat,
            lon;

        if (m.id < 0) {
            return null;
        }

        lat = parseFloat(dataitem[index]);
        lon = parseFloat(dataitem[index + 1]);
        if (Coordinates.valid(lat, lon)) {
            index += 2;
            m.coords = new google.maps.LatLng(lat, lon);
        } else {
            m.coords = Coordinates.fromString(dataitem[index]);
            index += 1;
        }
        if (!m.coords) {
            return null;
        }

        m.r = App.repairRadius(parseFloat(dataitem[index]), 0);
        index = index + 1;

        if (index < dataitem.length &&
                (/^([a-zA-Z0-9\-_]*)$/).test(dataitem[index])) {
            m.name = dataitem[index];
        }

        index = index + 1;
        if (index < dataitem.length &&
                (/^([a-fA-F0-9]{6})$/).test(dataitem[index])) {
            m.color = dataitem[index];
        }

        return m;
    }).filter(function (thing) {
        return thing !== null;
    });
};


Url.parseCenter = function (urlarg) {
    'use strict';

    if (!urlarg) {
        return null;
    }

    var data = urlarg.split(':');

    if (data.length === 1) {
        return Coordinates.fromString(data[0]);
    }

    if (data.length === 2) {
        return Coordinates.toLatLng(parseFloat(data[0]), parseFloat(data[1]));
    }

    return null;
};


Url.parseLines = function (urlarg) {
    'use strict';

    if (!urlarg) {
        return [];
    }

    /* be backwards compatible */
    if (urlarg.length === 3
            && alpha2id(urlarg[0]) >= 0
            && urlarg[1] === '*'
            && alpha2id(urlarg[1]) >= 0) {
        urlarg = urlarg[0] + ':' + urlarg[2];
    }

    return urlarg.split('*').map(function (pair_string) {
        var pair = pair_string.split(':');
        if (pair.length === 2) {
            return {source: alpha2id(pair[0]), target: alpha2id(pair[1])};
        }
        return null;
    }).filter(function (thing) {
        return (thing !== null);
    });
};


1			/*jslint
2			indent: 4
3			*/
4			/*global
5			google, window,
6			App, Coordinates,
7			alpha2id
8			*/
9
10			var Url = {};
11
12			Url.getParams = function () {
13			'use strict';
14
15			var params = {},
16			splitted = window.location.search.substr(1).split('&'),
17			i,
18			p;
19
20			for (i = 0; i < splitted.length; i += 1) {
21			p = splitted[i].split('=', 2);
22			if (p[0] !== "") {
23			if (p.length === 1) {
24			params[p[0]] = "";
25			} else {
26			params[p[0]] = decodeURIComponent(p[1].replace(/\+/g, " "));
27			}
28			}
29			}
30
31			return params;
32			};
33
34			Url.parseMarkers = function (urlarg) {
35			'use strict';
36
37			if (!urlarg) {
38			return [];
39			}
40
41			var data;
42
43			// ID:COODRS:R(:NAME)?\|ID:COORDS:R(:NAME)?
44			// COORDS=LAT:LON or DEG or DMMM
45			if (urlarg.indexOf("*") >= 0) {
46			data = urlarg.split('*');
47			} else {
48			/* sep is '\|' */
49			data = urlarg.split('\|');
50			}
51
52			return data.map(function (dataitem) {
53			dataitem = dataitem.split(':');
54			if (dataitem.length < 3 \|\| dataitem.length > 6) {
55			return null;
56			}
57
58			var m = {
59			alpha: dataitem[0],
60			id: alpha2id(dataitem[0]),
61			name: null,
62			coords: null,
63			r: 0,
64			color: ""
65			},
66			index = 1,
67			lat,
68			lon;
69
70			if (m.id < 0) {
71			return null;
72			}
73
74			lat = parseFloat(dataitem[index]);
75			lon = parseFloat(dataitem[index + 1]);
76			if (Coordinates.valid(lat, lon)) {
77			index += 2;
78			m.coords = new google.maps.LatLng(lat, lon);
79			} else {
80			m.coords = Coordinates.fromString(dataitem[index]);
81			index += 1;
82			}
83			if (!m.coords) {
84			return null;
85			}
86
87			m.r = App.repairRadius(parseFloat(dataitem[index]), 0);
88			index = index + 1;
89
90			if (index < dataitem.length &&
91			(/^([a-zA-Z0-9\-_]*)$/).test(dataitem[index])) {
92			m.name = dataitem[index];
93			}
94
95			index = index + 1;
96			if (index < dataitem.length &&
97			(/^([a-fA-F0-9]{6})$/).test(dataitem[index])) {
98			m.color = dataitem[index];
99			}
100
101			return m;
102			}).filter(function (thing) {
103			return thing !== null;
104			});
105			};
106
107
108			Url.parseCenter = function (urlarg) {
109			'use strict';
110
111			if (!urlarg) {
112			return null;
113			}
114
115			var data = urlarg.split(':');
116
117			if (data.length === 1) {
118			return Coordinates.fromString(data[0]);
119			}
120
121			if (data.length === 2) {
122			return Coordinates.toLatLng(parseFloat(data[0]), parseFloat(data[1]));
123			}
124
125			return null;
126			};
127
128
129			Url.parseLines = function (urlarg) {
130			'use strict';
131
132			if (!urlarg) {
133			return [];
134			}
135
136			/* be backwards compatible */
137			if (urlarg.length === 3
138			&& alpha2id(urlarg[0]) >= 0
139			&& urlarg[1] === '*'
140			&& alpha2id(urlarg[1]) >= 0) {
141			urlarg = urlarg[0] + ':' + urlarg[2];
142			}
143
144			return urlarg.split('*').map(function (pair_string) {
145			var pair = pair_string.split(':');
146			if (pair.length === 2) {
147			return {source: alpha2id(pair[0]), target: alpha2id(pair[1])};
148			}
149			return null;
150			}).filter(function (thing) {
151			return (thing !== null);
152			});
153			};
154

flopp / FloppsMap

GitHub Access Token became invalid

Push — master ( 137f54...278f6d )

Url.parseMarkers A

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like